Reduced Precision Number Display#8291
Open
Regisle wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Reduced Precision Number Display#8291Regisle wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Regisle wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
|
It's definitely more readable, I like it. Though the SI prefix for billions is G not B right? Which makes me think you might want to just stick with semantic prefixes, and maybe all in the same case (my preference would be lowercase). I don't think anyone is worried about Kelvin just yet, maybe next league... |
Regisle
force-pushed
the
ReducedPrecisionNumberDisplay
branch
from
06bd2d0 to
05fe6df
Compare
Zarloc
reviewed
Nov 30, 2024
| if #integer > 12 then | ||
| return colour..minus..integer:sub(1, #integer - 12)..fraction:gsub("%.", main.decimalSeparator).." T" | ||
| elseif #integer > 9 then | ||
| return colour..minus..integer:sub(1, #integer - 9)..fraction:gsub("%.", main.decimalSeparator).." B" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the number of digits shown, and instead opts to show
SI prefixes(k, M, B, T)I just ended up applying this to everything for now, its much harder to only apply it to dps becouse then I need to tag what does and does not get it applied to, I kept the same level of precision as the base number if it had any, (and 2 decimals if it didnt), I can standardise this to 2 if we want it.
This does not modify the values stored in the xml, only the values displayed in PoB itself.
This does have issues above 15 digits, I can either add more prefixes, or can let it continue in the function through
showThousandsSeparatorsto still get separated, but people shouldnt have numbers that big so I think this is fineI can cleanup code to not use if statements, but it shouldnt change much, so up to maintainer what they prefer for style