Skip to content

Fix many unique staves with Attack block instead of Spell block implicit #8580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Blitz54
Copy link
Contributor

@Blitz54 Blitz54 commented Mar 16, 2025

Fixes #8579

Description of the problem being solved:

The base type "Quarterstaff" for annihilating light was changed from 18% attack block to 22% spell block, but the current variant for the unique was using 22% attack block. Quick fix.

Steps taken to verify a working solution:

After screenshot:

image

@HeffU
Copy link
Contributor

HeffU commented May 12, 2025

Stumbled upon another staff implicit issue and it seems like uniques with certain bases had their implicit set to attack block instead of spell block.

Patch notes read: "Imperial Staff, Lathi, and Primordial Staff now have +25% Chance to Block Spell Damage while wielding a Staff (previously +18%)."

However, in the merged commit we can see that the uniques from the above listed bases got their values all set to Attack block rather than Spell block.

Maybe this PR can be changed to apply to all of the affected uniques?
(I don't mind doing it but since you already had this one up I figured I'd check here first)

@LocalIdentity LocalIdentity changed the title Fix Annihilating Light impilicit Fix many unique staves with Attack block instead of Spell block implicit Jun 6, 2025
@LocalIdentity LocalIdentity added the bug: accuracy Wording differences label Jun 6, 2025
@LocalIdentity LocalIdentity merged commit 61f3dfb into PathOfBuildingCommunity:dev Jun 6, 2025
2 checks passed
@Blitz54 Blitz54 deleted the annihilating-light branch June 16, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annihilating Light still has the old attack block implicit in PoB
3 participants