Add missing screen size conversions#9373
Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom Jan 28, 2026
Merged
Add missing screen size conversions#9373LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
`GetScreenSize` returns the size in physical units if the "DPI_AWARE" flag is passed to `RenderInit`. The error popup and restart screen have the wrong position and size at UI scaling factor != 1.0 due to missing conversions to virtual units. This introduces a utility function for getting the virtual screen size and uses it to add the missing conversions.
Contributor
Author
|
This also needs to be applied to PoB2. It looks like this can be automated by setting a label but i can also do it manually if wanted. |
Contributor
|
There's some edit: derp |
LocalIdentity
added
the
pob2
LocalIdentity
approved these changes
Jan 28, 2026
LocalIdentity
merged commit b96dbc2
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Jan 28, 2026
meehl
added a commit
to meehl/PathOfBuilding
that referenced
this pull request
Jan 29, 2026
* Add missing screen size conversions `GetScreenSize` returns the size in physical units if the "DPI_AWARE" flag is passed to `RenderInit`. The error popup and restart screen have the wrong position and size at UI scaling factor != 1.0 due to missing conversions to virtual units. This introduces a utility function for getting the virtual screen size and uses it to add the missing conversions. * Update export scripts --------- Co-authored-by: Jack Lockwood <jacklockwood1998@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetScreenSizereturns the size in physical units if theDPI_AWAREflag is passed toRenderInit. The error popup and restart screen have the wrong position and size at UI scaling factor != 1.0 due to missing conversions to virtual units.This introduces a utility function for getting the virtual screen size and uses it to add the missing conversions.
Before screenshot:
After screenshot: