This repository was archived by the owner on Jun 3, 2019. It is now read-only.
#70 - Improve Timestamp Accuracy #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickDuncan
force-pushed
the
timestamps
branch
from
b3e508a to
8fa7a43
Compare
levin-noro
suggested changes
Jan 7, 2019
PatrickDuncan
force-pushed
the
timestamps
branch
from
8fa7a43 to
0d57352
Compare
VictorCarri
previously approved these changes
Jan 8, 2019
Collaborator
VictorCarri
left a comment
VictorCarri
left a comment
There was a problem hiding this comment.
Good job! It's an interesting algorithm.
PatrickDuncan
force-pushed
the
timestamps
branch
from
90a15ef to
42a32b1
Compare
PatrickDuncan
force-pushed
the
timestamps
branch
from
42a32b1 to
fab22eb
Compare
VictorCarri
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty basic algorithm that looks at the number of syllables in a word and compares it to the expected number of syllables for the duration returned from GCS. If there is an extremity than the timestamp is shortened/lengthened.
The algorithm should definitely be improved in the future.