release 5.1.0 #630
Merged
release 5.1.0 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to fix errors w/ zenodo; 'metadata' level is not required
…to public data.
…est user account.
Add maps.js to the precompile list to fix issue 596.
Allow keyless guests
covariate editing pages to prevent the default "submit" action from being attempted. This fixes issue #585. Also removed an extraneous "Update" button. Make the "Show" page for covariates give a more user-friendly error message when the covariate lacks an association with a trait.
Fix covariate page issues
…This fixes issue 611.
Include "script.js" code to enable the "close" button in alert divs. …
Co-Authored-By: robkooper <[email protected]>
Fix for issue 618.
Fix to make sure dbfiles have valid filename
dlebauer
reviewed
Jan 14, 2019
| # Upload Wizard, the validation step will prevent reaching this code | ||
| # if a site without time zone is in the data file. But nothing | ||
| # prevents a site without time zone from being specified | ||
| # interactively. |
There was a problem hiding this comment.
@gsrohde you mean time zones aren't assigned automatically based on location?
There was a problem hiding this comment.
@dlebauer That is correct, unfortunately. When I added the time_zone column, I did create and use table of time-zone/location data to facilitate automatically populating the time_zone column for existing sites, but there is nothing built-in to do this when adding a new site.
dlebauer
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes