Add classad insert methods #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g lists in a classad
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for working with list attributes in ClassAds, including methods for creating, inserting, and appending list elements of various types.
- Adds methods for inserting list attributes with typed convenience functions
- Implements a method to incrementally build lists by appending elements
- Provides comprehensive test coverage for all new list manipulation methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| classad/classad.go | Adds InsertAttrList, InsertAttrListInt, InsertAttrListFloat, InsertAttrListString, InsertAttrListBool, InsertAttrListClassAd, and InsertListElement methods for working with list attributes |
| classad/classad_test.go | Adds comprehensive test coverage for all new list manipulation methods, testing creation, appending, empty lists, and type-specific list functions |
Removed the inconsistent early return from InsertAttrListClassAd. It now follows the same pattern as the other InsertAttrList* methods, using make([]ast.Expr, len(values)) which correctly handles empty slices. Co-authored-by: Copilot <[email protected]>
patrickbrophy
force-pushed
the
classad-inserts
branch
from
a74819a to
abf3661
Compare
Collaborator
|
Like the new generic-enabled version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds insert methods to classads and a method to insert items to an existing list attribute.