Rewrite the lexer to be streaming #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lexer previously could only work with a string, requiring various gymnastics to work with IO readers. Now, the lexer works with an `io.Reader` by default, greatly simplifying the task of reading multiple ClassAds from a file. Greatly increased the unit test coverage around the parser and lexers; even found a small bug that incorrectly handled flattening.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lexer previously could only work with a string, requiring various gymnastics to work with IO readers. Now, the lexer works with an
io.Readerby default, greatly simplifying the task of reading multiple ClassAds from a file.Greatly increased the unit test coverage around the parser and lexers; even found a small bug that incorrectly handled flattening.