Skip to content

Conversation

@turetske
Copy link
Collaborator

@turetske turetske commented Oct 14, 2024

…riable.

Added the Pelican variable Cache.Prefetch and used it to set the cache prefix value in the cache Changed its default from 20 to 0
Updated the xrootd config and cache templates accordingly

@turetske turetske marked this pull request as ready for review October 14, 2024 20:40
@jhiemstrawisc
Copy link
Member

…riable.

Added the Pelican variabled Cache.Prefix and used it to set the cache prefix value in the cache Changed its default from 20 to 0 Updated the xrootd config and cache templates accordingly

Just clarifying before I review, is this supposed to be Cache.Prefix like the description claims or Cache.Prefetch like the title claims?

@turetske
Copy link
Collaborator Author

…riable.
Added the Pelican variabled Cache.Prefix and used it to set the cache prefix value in the cache Changed its default from 20 to 0 Updated the xrootd config and cache templates accordingly

Just clarifying before I review, is this supposed to be Cache.Prefix like the description claims or Cache.Prefetch like the title claims?

Prefetch, I had just been dealing with a lot of Prefix stuff and the typo just came out.

I recommend waiting until I can fix the test failures, though.

Emma Turetsky added 2 commits November 6, 2024 14:49
…riable.

Added the Pelican variabled Cache.Prefix and used it to set the cache prefix value in the cache
Changed its default from 20 to 0
Updated the xrootd config and cache templates accordingly
@turetske turetske force-pushed the cache-prefix-configurable branch from 60b8f4c to 3b8e711 Compare November 6, 2024 21:54
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll approve pending the failing ubuntu tests (not sure if this is a known flaky test or not).

@turetske turetske force-pushed the cache-prefix-configurable branch from b0acf1e to b66c3e6 Compare November 11, 2024 22:18
@jhiemstrawisc jhiemstrawisc merged commit dbb8da6 into PelicanPlatform:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants