Persist server downtime #1673
Merged
Persist server downtime #1673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
added
enhancement
h2zh
force-pushed
the
persist-server-downtime
branch
from
b4132a0 to
ae05b0a
Compare
jhiemstrawisc
requested changes
Nov 1, 2024
h2zh
force-pushed
the
persist-server-downtime
branch
from
899ef09 to
e83cdd8
Compare
Contributor
Author
|
I think this PR needs to be squashed and merged |
jhiemstrawisc
requested changes
Nov 11, 2024
Member
jhiemstrawisc
left a comment
jhiemstrawisc
left a comment
There was a problem hiding this comment.
One very small change, otherwise things look good to me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables director to persist the origin/cache server downtime set by the admin in a sqlite db. Fundamentally, it syncs the existing variable
filteredServersin cache with theserver_downtimestable in db.To find the .sqlite db file more easily when testing, you can override the default Director.DbLocation to <directory_of_your_choice> (e.g. /workspaces/pelican/director.sqlite) in
pelican.yamlA little bit interpretation of the existing code:
filteredServershas a data fieldfilterType, which have the following types:Different filter types decide the server downtime is temporary or permanent. The new db in this PR coheres this logic.