Update/clarify Cache.<Data/Meta>Locations documentation
#1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@turetske I'm also requesting your review on this PR since it now modifies code and not just documentation. |
jhiemstrawisc
force-pushed
the
issue-1664
branch
from
334adb5 to
5cdbbf1
Compare
This commit introduces `Cache.StorageLocation` and `Cache.NamespaceLocation`, two new variables used to correct some of the behavior around setting locations for the cache's namespace, meta, and data directories. One crucial change here is that the data/meta directories are no longer exported under the namespace directory, which previously resulted in exposing these internal file representations to users who new to look for them. This also ties the namespace/meta/data directories to `Cache.StorageLocation`, allowing you to set all three to the same directory through a single config.
jhiemstrawisc
force-pushed
the
issue-1664
branch
from
5cdbbf1 to
1721c25
Compare
Turns out some tests don't call init config, so they weren't handling the deprecated config. This updates the test to use the new params so they set the correct values.
…ter deref Another issue fixed by a different commit exposed that failure to stop the test on this error generates a nil pointer dereference when we try to check the contents of a non-existent error. Using require.Error stops the test before reaching the dereference.
turetske
approved these changes
Nov 27, 2024
Collaborator
turetske
left a comment
turetske
left a comment
There was a problem hiding this comment.
Minor comments on some of the comments, but otherwise seems to test correctly with both old and new naming system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to clarify some of the language surrounding these configuration options and removes mention of
Xrootd.Mountwhich has no effect on caches.Closes #1664