Pass access_token to namespace getter #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CannonLock
commented
Nov 15, 2024
CannonLock
commented
- Fixes register buttons for non admin users
- Fixes register buttons for non admin users
- Fixes register buttons for non admin users
CannonLock
commented
Nov 15, 2024
| return checkAuthentication(data); | ||
| } else { | ||
| return data?.authenticated !== undefined; | ||
| return !!data?.authenticated; |
Contributor
Author
There was a problem hiding this comment.
Note this fixes another issue that I saw where the previous solution would consider you authenticated even if data.authenticated == false.
Collaborator
|
@CannonLock - could you please create a write-up of the underlying issue itself for posterity? |
- Fixes register buttons for non admin users
Contributor
Author
https://docs.google.com/document/d/1z6VgMSGXzO49keZenvYTS2xAXGkFsyHWZTjFONum2Ew/edit?usp=sharing TLDR: Things likely got tested using Federation in a box which carried over the auth cookies to the director which hid missing functionality |
Contributor
|
could you take a look at the failed linter test |
h2zh
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.