Include defaults in debug config print #1749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
approved these changes
Nov 18, 2024
Member
jhiemstrawisc
left a comment
jhiemstrawisc
left a comment
There was a problem hiding this comment.
Minor nitpick about whitespace, but otherwise LGTM! I'll pre-approve, and you can merge after you make the change.
config/config.go
Outdated
|
|
||
| // PrintClientConfig prints the client config in JSON format to stderr. | ||
| func PrintClientConfig() error { | ||
|
|
Member
There was a problem hiding this comment.
Can you remove this whitespace?
Saartank
force-pushed
the
include-defaults-in-debug-config-print
branch
from
01ab99b to
6412cc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1720: On server startup, prints the full configuration after applying defaults if log level is INFO or higher. On client initialization, prints client-specific configuration when log level is DEBUG.