Add Version info to ServerAd #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
turetske
requested changes
Nov 25, 2024
Collaborator
turetske
left a comment
turetske
left a comment
There was a problem hiding this comment.
Two things.
1.) If the adV2 that the director gets from the origin/cache doesn't contain a version (so from anything older than this commit), we still want to be able to get the version. I know I said we'd discuss it later, but I think it's better as part of this PR, in hindsight. So in that case, get the version from the 'User-Agent' string.
2.) Write a unit test to ensure it gets the version properly in either case.
patrickbrophy
force-pushed
the
fix-issue-1725
branch
from
4829408 to
54de7ec
Compare
turetske
requested changes
Dec 6, 2024
turetske
approved these changes
Dec 10, 2024
Collaborator
turetske
left a comment
turetske
left a comment
There was a problem hiding this comment.
Looks good to me, I'll merge once the tests have passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1725. This PR adds a version field to the server ad. The goal is use this version field in the future for monitoring purposes.