Attempt longer ctx deadline in flaky localcache test #1756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
force-pushed
the
debug-localcache-test
branch
from
4cd8b03 to
e60a8b1
Compare
jhiemstrawisc
force-pushed
the
debug-localcache-test
branch
from
d831521 to
6cfbe12
Compare
turetske
approved these changes
Nov 22, 2024
Member
Author
|
Adding a note for posterity -- this was fixed by early commits, but the fix wasn't noticed because of our test infrastructure. When we calculate the previous code coverage, we checkout main and re-run tests. Because the bug existed in main, I was misinterpreting the failure as "my fixes aren't working" instead of "this was broken beforehand". See issue #1768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a flaky test for too long, and I've even seen it start failing locally when I'm running heavy Docker processes in the background. Clearly something just needs a bit more time to do its thing.