Fix OSDF Director startup warnings and separate GeoIP metric collection #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell. Also use GeoIPError to update metric
…removal of some context drilling
patrickbrophy
added
bug
jhiemstrawisc
requested changes
Dec 3, 2024
jhiemstrawisc
approved these changes
Dec 4, 2024
Member
jhiemstrawisc
left a comment
jhiemstrawisc
left a comment
There was a problem hiding this comment.
LGTM, and I no longer see the errors pop up when spinning up an OSDF Director. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1717. This PR fixes the unnecessary logging and separates out the GeoIP error metric collection. This is achieved via using a custom error type. This new error type carries along the prometheus labels. When we observe this new error type, we then update the metric with the passed along labels.