Take out the script that auto formats webUI PR from GitHub Actions#2650
Merged
h2zh merged 2 commits intoPelicanPlatform:mainfrom Sep 18, 2025
Merged
Take out the script that auto formats webUI PR from GitHub Actions#2650h2zh merged 2 commits intoPelicanPlatform:mainfrom
h2zh merged 2 commits intoPelicanPlatform:mainfrom
Conversation
Signed-off-by: Cannon Lock <clock@wisc.edu>
Contributor
|
The PR adds a condition to only run the formatter if the pull request's source branch is internal to the repository ( PelicanPlatform/pelican). However, in reality we all create pull request from a fork (i.e. this PR is from CannonLock/pelican, and |
Contributor
Author
|
@h2zh Yeah, it will barely ever run. I can also just take it out and move it to pre-commit. |
Contributor
|
@CannonLock I agree. Let's move it to pre-commit so that it can actually function, instead of being a ghost bot. |
Signed-off-by: Cannon Lock <clock@wisc.edu>
Contributor
Author
h2zh
changed the title
h2zh
approved these changes
Sep 18, 2025
Contributor
h2zh
left a comment
h2zh
left a comment
There was a problem hiding this comment.
LGTM. I rename this PR to reflect its up-to-date intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the formatter runs on PR's that it cannot edit which is resulting in a error. This update checks that the PR is coming from a branch on this repository and not a fork before it tries to automatically fix things.
Only run the formatter if that action can write to the repository in question.
If it comes form a fork then don't try to auto format.
Here is a example of the action running on a internal branch: #2649