Validate filesystem perms against namespace capabilities for posix origins #2881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the configured capabilities - Read+execute permissions for Reads, PublicReads, and Listings capabilities - Write+execute permissions for Writes capability - Also require storage prefix exists and is a directory
Replace made-up storage prefixes with temp directories that have proper permissions, because: Tests run as root, but the permission check simulates what the xrootd daemon user would have. Since xrootd is neither the owner nor in root's group, it falls into the "Others" category. Setting 0777 ensures the "others" bits grant full access (rwx).
h2zh
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the xrootd user has the required filesystem permissions for the configured capabilities
Also update tests to replace made-up storage prefixes with temp directories that have proper permissions, because: