Fix race condition in TestDirectorRegistration and goroutine leaks #2919
+41
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
added
bug
bbockelm
force-pushed
the
fix-director-registration-race
branch
from
87e8a9f to
a9294c4
Compare
- Fix federation discovery race: Force GetFederation() to run immediately after setting config to prevent sync.Once from capturing empty viper state - Fix nil pointer dereferences: Check for nil before calling Value() on cache lookups in 7 test cases - Fix goroutine leaks: Properly capture and wait for cancel/egrp in TestDiscoverOriginCache, TestRedirects, and TestGetHealthTestFile The sporadic test failure occurred when background goroutines called GetFederation() between ResetConfig() and param.Set(), causing the sync.Once to execute with empty config and cache that state permanently.
bbockelm
force-pushed
the
fix-director-registration-race
branch
from
a9294c4 to
997e553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sporadic test failure occurred when background goroutines called GetFederation() between ResetConfig() and param.Set(), causing the sync.Once to execute with empty config and cache that state permanently.
Fixes: #2918