Skip to content

Fix director's stat feature to no longer "leak" goroutines #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhiemstrawisc merged 1 commit into from
Jan 12, 2026
Merged

Fix director's stat feature to no longer "leak" goroutines #2935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions director/stat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,12 @@ func (stat *ObjectStat) queryServersForObject(ctx context.Context, objectName st
return
}
timeout := param.Director_StatTimeout.GetDuration()
// Note there is a small buffer in each channel; in the case of a cache hit, we write
// to the channel from within this goroutine.
positiveReqChan := make(chan *objectMetadata, 5)
negativeReqChan := make(chan error, 5)
deniedReqChan := make(chan *headReqForbiddenErr, 5) // Requests with 403 response
// We both send to *and* receive from these channels within this
// goroutine, so ensure that they have sufficiently large buffers
// to prevent the goroutine from blocking on itself.
positiveReqChan := make(chan *objectMetadata, len(ads))
negativeReqChan := make(chan error, len(ads))
deniedReqChan := make(chan *headReqForbiddenErr, len(ads)) // Requests with 403 response
// Cancel the rest of the requests when requests received >= max required
maxCancelCtx, maxCancel := context.WithCancel(ctx)
numTotalReq := 0
Expand Down Expand Up @@ -489,14 +490,13 @@ func (stat *ObjectStat) queryServersForObject(ctx context.Context, objectName st
}
totalLabels["cached_result"] = "true"
if metadata := item.Value(); metadata != nil {
totalLabels["result"] = string(metrics.StatSucceeded)
metrics.PelicanDirectorStatTotal.With(totalLabels).Inc()
log.Tracef("Object %s found at %s server %s: (cached result)", objectName, serverAd.Type, baseUrl.String())
positiveReqChan <- metadata
totalLabels["result"] = string(metrics.StatSucceeded)
} else {
log.Debugf("Object %s not found at %s server %s: (cached result)", objectName, serverAd.Type, baseUrl.String())
log.Tracef("Object %s not found at %s server %s: (cached result)", objectName, serverAd.Type, baseUrl.String())
negativeReqChan <- &headReqNotFoundErr{}
totalLabels["result"] = string(metrics.StatNotFound)
metrics.PelicanDirectorStatTotal.With(totalLabels).Inc()
}
metrics.PelicanDirectorStatTotal.With(totalLabels).Inc()
} else {
Expand Down
Loading