Stubs for two prometheus endpoints #2936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Return empty results instead of nil to prevent nil pointer panics when external tools (like Grafana) query the /rules or /alerts endpoints
7 tasks
patrickbrophy
requested changes
Jan 5, 2026
Contributor
patrickbrophy
left a comment
patrickbrophy
left a comment
There was a problem hiding this comment.
@h2zh Could you write a small test to ensure that hitting these endpoints doesn't cause any undesirable behavior? Otherwise the stub implementation looks good.
- stubs for /rules and /alerts endpoints
- Removed the simple unit tests earlier because they are covered by the new comprehensive tests
patrickbrophy
approved these changes
Jan 15, 2026
Contributor
patrickbrophy
left a comment
patrickbrophy
left a comment
There was a problem hiding this comment.
Thanks for the tests. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quick fix of the linked issue is removing Grafana's access to Prometheus'
/rulesand/alertsendpoints, which is already done. This PR is a permanent fix:Return empty results instead of nil to prevent nil pointer panics when external tools (like Grafana) query Prometheus'
/rulesor/alertsendpoints