Prevent test suite from killing Docker init process #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickbrophy
added
bug
Member
|
This fix works as advertised, and with it my dev container doesn't die anymore. @bbockelm, is there a reason this test should be sending a |
jhiemstrawisc
approved these changes
Jan 5, 2026
Collaborator
|
Change is OK! Looks like the underlying problem here is the default was being interpreted as a valid value. That can still happen! 99999 could be a PID. Can I request a tweak to have it something like 0 instead? That would clear up the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2944. This PR prevents the XRootD restart feature from killing PID 1 and updates the test to use dummy PIDs.