-
Notifications
You must be signed in to change notification settings - Fork 10
Version bump for Globus changes #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jhiemstrawisc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, otherwise LGTM. I didn't test actually building it, but the changes look reasonable.
rpm/xrootd-s3-http.spec
Outdated
| Version: 0.5.3 | ||
| Version: 0.6.0 | ||
| Release: 1%{?dist} | ||
| Summary: S3/HTTP filesystem plugins for xrootd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also update the summary to include Globus. Technically we've squeezed a bunch of other stuff in here, too, but I think the 3 things 99.9% of people will install this package for are HTTP/S3/Globus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you commit it? I still see "S3/HTTP filesystem plugins for xrootd".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't realize you meant the top level summary. I amended my commit
a4ee1d2 to
f952b8c
Compare
jhiemstrawisc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumping the minor version for the XRootD http plugin to account for a new shared object created by this PR.