Skip to content

Conversation

@whwjiang
Copy link
Contributor

Bumping the minor version for the XRootD http plugin to account for a new shared object created by this PR.

Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise LGTM. I didn't test actually building it, but the changes look reasonable.

Version: 0.5.3
Version: 0.6.0
Release: 1%{?dist}
Summary: S3/HTTP filesystem plugins for xrootd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also update the summary to include Globus. Technically we've squeezed a bunch of other stuff in here, too, but I think the 3 things 99.9% of people will install this package for are HTTP/S3/Globus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did

Copy link
Member

@jhiemstrawisc jhiemstrawisc Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you commit it? I still see "S3/HTTP filesystem plugins for xrootd".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize you meant the top level summary. I amended my commit

Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whwjiang whwjiang merged commit e7dd407 into PelicanPlatform:main Dec 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants