[docs] Fix documentation for MLIR plugins #1527
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erick-xanadu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Fixes one part of #1515
Description of the Change: Documents changes to the build system to avoid changes from being overriden by the copy command. Along with removing the
pluginmake rule from themake alldependencies. The plugin would be build as part of Catalyst's build command.Benefits: Clearer instructions.
Possible Drawbacks: I would like some time to improve the building setup for plugins as stated in ticket #1515. This would allow building the plugin without as many changes to the default plugin build system since it would be only using Catalyst's include directories and generated files.
Related GitHub Issues: