Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9021 +/- ##
==========================================
- Coverage 99.44% 99.44% -0.01%
==========================================
Files 601 601
Lines 64883 64917 +34
==========================================
+ Hits 64523 64555 +32
- Misses 360 362 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
The _update_counts_from_compressed_res_ops was doing brute force recursive tree traversal, which scales exponentially. As the recursive depth increases, this will lead to serious performance degradation.
Description of the Change:
We implement memoization to reduce the time complexity to polynomial.
Benefits:
Dramatic speed up of XAS notebook from 3 minutes to 4 seconds.
Possible Drawbacks:
None
Related GitHub Issues: