Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to t/run/todo.t #22680

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from
Open

Conversation

khwilliamson
Copy link
Contributor

  • This set of changes does not require a perldelta entry.

t/run/todo.t Outdated Show resolved Hide resolved
@jkeenan
Copy link
Contributor

jkeenan commented Oct 19, 2024

Test failed CI; please see https://github.com/Perl/perl5/pull/22680/checks

@jkeenan
Copy link
Contributor

jkeenan commented Oct 24, 2024

I checked out this branch, rebased on blead, built and tested. I got this result.

$ cd t;./perl harness -v run/todo.t; cd -

ok 1 - GH \#16894
not ok 2 - "abcde5678" =~ / b (*pla:.*(*plb:(*plb:(.{4}))? (.... # TODO GH 16250
ok 3 - No assertion failure # TODO GH 16876
ok 4 - No assertion failure # TODO GH 16952
not ok 5 - No assertion failure # TODO GH 16971
ok 6 - No assertion failure # TODO GH 16627
ok
All tests successful.

Test Summary Report
-------------------
run/todo.t (Wstat: 0 Tests: 6 Failed: 0)
  TODO passed:   3-4, 6
Files=1, Tests=6,  0 wallclock secs ( 0.00 usr  0.00 sys +  0.02 cusr  0.01 csys =  0.03 CPU)
Result: PASS

Is there a better place to put tests that were once TODOed but are now passing?

@khwilliamson
Copy link
Contributor Author

There may be a better place, but I left it here to show that it could be left here.

@tonycoz
Copy link
Contributor

tonycoz commented Nov 6, 2024

Don't these belong in the test scripts that test that particular op? like the many other TODO tests?

@khwilliamson
Copy link
Contributor Author

Yes, but my goal here was to make it easier for someone to just start going through tickets and copying the tests without having to think about anything more than necessary. They can be moved later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants