pv_uni_display: Revert use of utf8_to_uv_or_die #23093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Perl#23089 Croaking when someone is trying to output a malformed UTF-8 sequence turns out to be a bad idea. That should have been obvious to me. But instead of going back to the problematic utf8_to_uvchr_buf(), this commit uses the non-croaking utf8_to_uv(). Croaking should not be done when at the user interface. It makes sense, for example, when things should have already been validated and there is no good option to proceed.
khwilliamson
force-pushed
the
fix_print_or_die
branch
from
a1b056a to
c601eb5
Compare
khwilliamson
changed the title
khwilliamson
changed the title
khwilliamson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #23089
Croaking when someone is trying to output a malformed UTF-8 sequence turns out to be a bad idea. That should have been obvious to me.
But instead of going back to the problematic utf8_to_uvchr_buf(), thiscommit uses the non-croaking utf8_to_uv().
Croaking should not be done when at the user interface. It makes sense, for example, when things should have already been validated and there is no good option to proceed.