Skip to content

Conversation

khwilliamson
Copy link
Contributor

This is deprecated, but we should give enough information to tell people what to do. And this moves it to the public API so that its deprecation gets more prominence.

  • This set of changes does not require a perldelta entry.

This is deprecated, but we should give enough information to tell people
what to do.  And this moves it to the public API so that its deprecation
gets more prominence.
Copy link
Contributor

@jkeenan jkeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build a perl from the branch in this pull request and follow its guidance to develop a patch to a CPAN module in which a 'deprecated-declaration' warning was being emitted. So the p.r. appears to do what it says on the tin. However, since I'm a novice at embed.fnc, someone familiar with that should review the actual code.

Side note: Is there any definitive way of determining when uv_to_utf8 first became available to XS authors? The upstream maintainer of the module in question will be concerned with backwards compatibility.

@khwilliamson
Copy link
Contributor Author

I'm working on a new release of Devel::PPPort which will port these back to 5.7

@jkeenan
Copy link
Contributor

jkeenan commented Aug 24, 2025

I'm working on a new release of Devel::PPPort which will port these back to 5.7

For reference, I traversed a minicpan repository looking for *.c, *.h and *.xs files containing the pattern /uvuni_to_utf8(_flags)?/. Results:

$ perl uvuni_to_utf8-files.pl 
1081 minicpan tarballs had files matching /uvuni_to_utf8(_flags)?/
133 different filenames with /uvuni_to_utf8(_flags)?/ seen
1119 files overall
1071 files basenamed ppport.h

So, is this deprecation still advisable?

@khwilliamson
Copy link
Contributor Author

The _flags form isn't deprecated. And ppport.h isn't a problem. How many distros are left that have uses besides these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants