Skip to content

No need to default-construct logger in the declaration #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

No need to default-construct logger in the declaration #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ...ter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ struct StackParams {
}

ParamListener(const std::shared_ptr<rclcpp::node_interfaces::NodeParametersInterface>& parameters_interface,
rclcpp::Logger logger, std::string const& prefix = "") {
logger_ = std::move(logger);
prefix_ = prefix;
rclcpp::Logger logger, std::string const& prefix = "")
: logger_{std::move(logger)},
prefix_{prefix} {
if (!prefix_.empty() && prefix_.back() != '.') {
prefix_ += ".";
}
Expand Down Expand Up @@ -220,10 +220,7 @@ struct StackParams {
std::shared_ptr<rclcpp::node_interfaces::OnSetParametersCallbackHandle> handle_;
std::shared_ptr<rclcpp::node_interfaces::NodeParametersInterface> parameters_interface_;

// rclcpp::Logger cannot be default-constructed
// so we must provide a initialization here even though
// every one of our constructors initializes logger_
rclcpp::Logger logger_ = rclcpp::get_logger("{{namespace}}");
rclcpp::Logger logger_;
std::mutex mutable mutex_;
};

Expand Down
Loading