Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET demo #38

Merged
merged 25 commits into from
Feb 27, 2025
Merged

.NET demo #38

merged 25 commits into from
Feb 27, 2025

Conversation

picoliu
Copy link
Contributor

@picoliu picoliu commented Feb 21, 2025

No description provided.

@picoliu picoliu requested a review from laves February 21, 2025 21:20
@picoliu picoliu requested a review from matt200-ok February 21, 2025 21:22
matt200-ok
matt200-ok reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@matt200-ok matt200-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a dotnet codestyle action for this demo.

@picoliu picoliu requested a review from matt200-ok February 25, 2025 00:34
laves
laves requested changes Feb 25, 2025
View reviewed changes
Copy link
Member

@laves laves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the feedback is general that applies to many areas. Reread your code with them in mind and fix along the way.

@picoliu picoliu requested a review from laves February 25, 2025 22:09
@picoliu picoliu requested a review from laves February 25, 2025 23:28
laves
laves requested changes Feb 26, 2025
View reviewed changes
@picoliu picoliu requested a review from laves February 27, 2025 00:23
@laves laves merged commit 4a1391f into main Feb 27, 2025
3 checks passed
@laves laves deleted the dotnet-demo branch February 27, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laves laves laves approved these changes

@matt200-ok matt200-ok matt200-ok approved these changes

Assignees

@laves laves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picoliu @laves @matt200-ok