Skip to content

[BUG] Update Page does not support Status type #6310 #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lcaresia
Copy link
Collaborator

@lcaresia lcaresia commented May 9, 2023

WHAT

🤖 Generated by Copilot at 9d1ae4d

Improved the notion package by adding more options and fixing issues for the update page action. Updated the pnpm-lock.yaml and package.json files with the latest package versions and dependencies.

🤖 Generated by Copilot at 9d1ae4d

We update the page with the power of Notion
We handle the select property with skill and devotion
We fix the issues and add more options
We rock the code with the latest versions

WHY

HOW

🤖 Generated by Copilot at 9d1ae4d

  • Bumped version of update page action and added debug log (link, link)
  • Improved handling of select property values in convertToNotion function (link)
  • Updated notion package version and removed unused lodash dependency (link, link)
  • Added new components for h_supertools_analytics_tool, implisense_api, and liondesk to pnpm-lock.yaml (link, link, link)

@lcaresia lcaresia added the enhancement New feature or request label May 9, 2023
@lcaresia lcaresia self-assigned this May 9, 2023
@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pipedream-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 1:31pm
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 1:31pm

@lcaresia lcaresia linked an issue May 9, 2023 that may be closed by this pull request
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lcaresia , thanks for the fix, looks good to me! Just check if that console.log should remain there.

Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lcaresia , thanks for the fix, looks good to me! Just check if that console.log should remain there.

@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
Notion_6372_1031.pdf

@vunguyenhung
Copy link
Collaborator

vunguyenhung commented May 11, 2023

Hello @lcaresia,

I have tested again, but even though I added the variable following the description, the notion page Status field still not updated.

I have the page with Status = In progress
image

Then I updated it to Not started with the full object (I also tried with only the name field), but the Status property is still not updated per the response
FireShot Capture 406 - Untitled Workflow - Pipedream - pipedream com

Would you mind testing on your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Update Page does not support Status type
4 participants