Better event fetching code for e2e tests #1375
Conversation
| -- | race x y = race y x | ||
| -- | race x (race y z) = race (race x y) z | ||
| -- | race never x = x | ||
| race :: forall (a :: Type). Aff a -> Aff a -> Aff a |
There was a problem hiding this comment.
How does this differ from:
race f g = sequential (parallel (try f) <|> parallel (try g)) >>= liftEitherThere was a problem hiding this comment.
Indeed. This should be the same. Nice catch.
kirill-havryliuk
force-pushed
the
k.havryliuk/better-event-fetching-code-for-e2e-tests
branch
from
50e0bbb
to
d6e2e11
Compare
| let | ||
| -- Asyncronously gets browser events and pushes | ||
| -- to the `eventVAar` one by one. | ||
| watcher = fix \this -> do |
There was a problem hiding this comment.
FWIW You don't need to fix under monadic recursion for Aff, ie you can use watcher directly and recursively here (and in the other places you have used fix, if you gave them names)
There was a problem hiding this comment.
Sure. That's the matter of taste. I prefer to use fix.
There was a problem hiding this comment.
This is just less verbose, imho.
foo bar baz quux = something *> foo bar baz quux
foo bar baz quux = fix \this -> something *> this
foo bar baz quux = let this = foo bar baz quux in something *> this
PS.
Well, foo, has a bunch of arguments, and this is not a honest comparison.
watch = something *> watch
watch = fix \this -> something *> this
For me it is just a matter of taste, as I told earlier. :)
Co-authored-by: Joseph Young <[email protected]>
kirill-havryliuk
force-pushed
the
k.havryliuk/better-event-fetching-code-for-e2e-tests
branch
from
8953a81
to
cf13dc8
Compare
| throwError (error nextAfterConfirmAccess) | ||
| ] |
There was a problem hiding this comment.
This effectively sets 100 seconds timeout for every test. It's not what we want, the test suite should control the timeouts, not the testing engine.
| , delaySec (Seconds 100.0) *> | ||
| throwError (error nextAfterSign) |
| , delaySec (Seconds 10.0) *> throwError | ||
| (error nextAfterConfirmAccess) | ||
| ] |
| ] | ||
| Sign -> handler =<< raceMany | ||
| [ waitNextEvent | ||
| , delaySec (Seconds 10.0) *> throwError (error nextAfterSign) |
Pre-review checklist
make format)Mostly, refactoring of subscribeToBrowserEvents function.