Skip to content

Conversation

@hua7450
Copy link
Collaborator

@hua7450 hua7450 commented Sep 10, 2025

Fixes #6531

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (920809c) to head (1713659).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #6526    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1        36    +35     
  Lines           31       488   +457     
==========================================
+ Hits            31       488   +457     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hua7450 hua7450 marked this pull request as ready for review September 11, 2025 15:43
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structural suggestions

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments apply across the deductions

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, LGTM after those, we will need to make sure these changes are communicated before we merge

from policyengine_us.model_api import *


class snap_prorate_earned_income_exclusion_person(Variable):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class snap_prorate_earned_income_exclusion_person(Variable):
class snap_earned_income_exclusion_ineligible_member(Variable):

from policyengine_us.model_api import *


class snap_prorate_unearned_income_exclusion_person(Variable):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class snap_prorate_unearned_income_exclusion_person(Variable):
class snap_unearned_income_exclusion_ineligible_member(Variable):

child_support = person("child_support_expense", period)

# Apply proration only for ineligible members
is_prorate_person = person(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is_prorate_person = person(
is_ineligible_member = person(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add prorated income and deductions for SNAP

2 participants