-
Notifications
You must be signed in to change notification settings - Fork 201
SNAP Adjustment #6526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SNAP Adjustment #6526
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6526 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 1 36 +35
Lines 31 488 +457
==========================================
+ Hits 31 488 +457
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structural suggestions
policyengine_us/variables/gov/usda/snap/eligibility/snap_immigration_status_eligible_person.py
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/eligibility/snap_unit/is_snap_unit_eligible_person.py
Outdated
Show resolved
Hide resolved
...ables/gov/usda/snap/income/deductions/self_employment/snap_self_employment_income_expense.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/gross/snap_proration_factor.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/gross/snap_gross_income.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments apply across the deductions
policyengine_us/variables/gov/usda/snap/eligibility/snap_immigration_status_eligible_person.py
Show resolved
Hide resolved
...s/variables/gov/usda/snap/income/deductions/shelter/snap_excess_shelter_expense_deduction.py
Outdated
Show resolved
Hide resolved
...s/variables/gov/usda/snap/income/deductions/shelter/snap_excess_shelter_expense_deduction.py
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/deductions/snap_child_support_deduction.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/gross/is_snap_prorate_person.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/gross/snap_unit_prorate_people_count.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/gross/snap_eligible_share_of_expense.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/deductions/shelter/snap_housing_cost.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/deductions/shelter/snap_housing_cost_person.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/deductions/shelter/snap_housing_cost_person.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/deductions/shelter/snap_housing_cost_person.py
Outdated
Show resolved
Hide resolved
...ne_us/variables/gov/usda/snap/income/deductions/shelter/snap_individual_utility_allowance.py
Outdated
Show resolved
Hide resolved
...s/variables/gov/usda/snap/income/deductions/shelter/snap_excess_shelter_expense_deduction.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/usda/snap/income/deductions/snap_dependent_care_deduction.py
Show resolved
Hide resolved
...gine_us/tests/policy/baseline/gov/usda/snap/income/deductions/shelter/snap_housing_cost.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits, LGTM after those, we will need to make sure these changes are communicated before we merge
| from policyengine_us.model_api import * | ||
|
|
||
|
|
||
| class snap_prorate_earned_income_exclusion_person(Variable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| class snap_prorate_earned_income_exclusion_person(Variable): | |
| class snap_earned_income_exclusion_ineligible_member(Variable): |
| from policyengine_us.model_api import * | ||
|
|
||
|
|
||
| class snap_prorate_unearned_income_exclusion_person(Variable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| class snap_prorate_unearned_income_exclusion_person(Variable): | |
| class snap_unearned_income_exclusion_ineligible_member(Variable): |
| child_support = person("child_support_expense", period) | ||
|
|
||
| # Apply proration only for ineligible members | ||
| is_prorate_person = person( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| is_prorate_person = person( | |
| is_ineligible_member = person( |
Fixes #6531