Remove deprecated 'name' metadata field from parameters #6674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'name' metadata field in parameter files is deprecated and no longer used. This commit removes the field from all 51 parameter files where it was present. The parameters continue to work correctly without this field, as validated by loading the tax-benefit system successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
Author
|
Closing this PR. Reopening the original PR #6673 instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6674 +/- ##
===========================================
- Coverage 99.55% 76.68% -22.88%
===========================================
Files 30 3188 +3158
Lines 453 45860 +45407
Branches 1 235 +234
===========================================
+ Hits 451 35169 +34718
- Misses 1 10670 +10669
- Partials 1 21 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
namemetadata field from 51 parameter filesnamefield is no longer used in the parameter systemChanges
name:field from metadata sections in 51 YAML parameter files across:Test plan
namefieldNotes
The
namemetadata field was a deprecated field that is no longer used by policyengine-core. All parameters continue to function correctly without this field.Rebased on latest master to resolve merge conflict in PA eligibility_income_sources.yaml.
🤖 Generated with Claude Code