Added Cloudflare for Review #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
doamatto
requested changes
May 23, 2025
Collaborator
doamatto
left a comment
doamatto
left a comment
There was a problem hiding this comment.
Sorry for the late review— it's a good start, but there's more work that needs to be done
products/cloudflare.toml
Outdated
| "We do not allow our third-party service providers to use your personal data for their own purposes or to sell your personal data. We only permit them to process your personal data for specified purposes and in accordance with our instructions.” Source: Cloudflare Candidate Privacy Notice", | ||
| "Cloudflare shall not subcontract any of its processing operations performed on behalf of the Customer under the Clauses without the prior written consent of the Customer.” Source: Cloudflare Data Processing Addendum" | ||
| ] | ||
| notes = [ |
Collaborator
There was a problem hiding this comment.
There should be/is a more graceful way to handle attributing quotes
Contributor
Author
Thanks for the review. Can you take a look again. I've made certain changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request: product addition
Related issues: Issue #207 (Add Cloudflare)
Please review this pull request and let me know if any changes are needed.