-
-
Notifications
You must be signed in to change notification settings - Fork 33
Update and add services #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
doamatto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have time to check this out tomorrow LA time, but I figured I'd give these notes before then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's what I've got — thanks for the work so far ^_^
| value = "yes" | ||
| citations = [ | ||
| "\"We change this Privacy Policy from time to time. We will not reduce your rights under this Privacy Policy without your explicit consent. We always indicate the date the last changes were published and we offer access to archived versions for your review. If changes are significant, we’ll provide a more prominent notice (including, for certain services, email notification of Privacy Policy changes).\"" | ||
| "\"[...] we offer access to archived versions for your review.\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think reducing this is fine, but I feel this gets too reductive, if that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the part that is needed in "history", so I just took that one.
If feel if leaving the rest, it would just be unneeded information
|
Sorry for this sliding in here, but I added matrix |
Type of pull request: product addition / product edit
Related issues: list the related issues here (if applicable)
All tests passed.