Remove CDD claim checks and add DID Registrars by tgntr · Pull Request #1873 · PolymeshAssociation/Polymesh

tgntr · 2026-02-03T08:44:15Z

This PR removes the CDD claim requirement and replaces it with a simpler DID existence check.

changelog

new features

Replaced CDD claim checks with DID existence checks - has_valid_cdd() → is_did_active()
Added new register_did extrinsic - simplified DID registration without secondary keys support

other

Renamed CddServiceProviders → DidRegistrars across all runtimes and config traits and related types/functions/errors
Deprecated CDD extrinsics - cdd_register_did, cdd_register_did_with_cdd, invalidate_cdd_claims, change_cdd_requirement_for_mk_rotation
Removed CDD RPC methods - is_identity_has_valid_cdd and valid_cdd_claims
Removed dead CDD validation code
Added new tests for register_did and updated existing tests/benchmarks
Updated polymesh_schema.json
Updated CLI types in scripts/cli/src/interfaces

* Start moving our changes out of the core Staking code. * Refactor chill/nominate code. * Refactor slashing switch. * Add missing "Polymesh added" notes. * FIXUP * Access Polymesh staking logic through an associated type. * Impl PermissionedStaking on the pallet. * Refactor some of our logic out of the benchmarking and testing code. * Avoid using our User type. * Add ED check to trait.

* Revert benchmarking and testing utils to Substrate code. * Port our staking benchmarks onto the Substrate code. * Split the permissioned validator logic into a different pallet. * Update tests. * cargo fmt * Move Polymesh types out of staking pallet. * Cleanup * Clean and revert some changes. * Import Substrate mock/tests. * Use staking pallet from Substrate. * Fix tests. * Remove old PolymeshStorageVersion. * Remove unused events. * Add migration. * Switch Substrate branches. * FIXUP: weights.

* Remove pallet-balances * Fix benchmarks * Remove cdd check; Fix bench * Fix bench and integration tests * Add polymesh_v8 feature to polymesh-api * Update ci commands * Change ci flag * Remove error

* Add workspace dependency * Update Substrate * Update WeightMeter * Deprecated GenesisBuild, use BuildGenesisConfig * Use Weight::from_parts instead of Weight::from_ref_time * T::BlockNumber update * Fix chrono deprecated warnings. * Fix deprecated check_accrue call. * Add TypeInfo to Runtime API types. * System pallet renamed Index -> Nonce. * Update contracts * Update weights * Bump recursion_limit * Update Babe and Grandpa. * Update staking pallet * Update im-online. * Require serde. * no_std GenesisConfig. * Update node binary service/command code. * Add missing runtime_version attribute. * Fix wasm-builder * Remove old test. * Fix warnings. * Fix warnings about OldWeight. * Fix benchmark build. * Fix RPC port number. * System.set_code doesn't use max block weight anymore. * Use sensible maths for `from_rational`. paritytech/substrate#13660 * Bump contract gas fees. * Add NoopMigration for v10 contracts pallet. * Add feature flag for ed; Fix tests and runtime * Update Weights * Fix integration tests * Update .toml and .lock; Update rustc --version; Remove old testing feature * Fix compilation errors - part I * Fix compilation errors - part II * Fix compilation errors - part III * Fix compilation errors - part IV * Fix compilation errors - Tx payment * Fix compilation errors - Remove deprecated scheduler * Fix compilation erros - Impl TransactionExtension for pallet_permissions * Fix compilation errors - Remove deprecated scheduler * Remove deprecated calls - pallet_sudo pallet_validators * Fix compilation errors - pallet_tx_payments currency adapter * Fix compilation errors - Update dependency; add Preimage * Update develop runtime * Update mainnet and testnet runtime * Fix rpc-protocol-fee - part I * Fix node-rpc errors - part I * Fix node-rpc errors * Fix group and protocol rpc build * Updating node part I * Update node part II * Update chain_spec - part I * Update chain spec - part II * Update node - part III * Remove warnings; Remove local dependecies * Impl TransactionExtension * Add missing GenesisBuilder impl; Use camel case for json genesis; Add validators genesis config * Remove duplicated chainspec merge; Update toml; Cargo fmt * Update rust version * Add ci_runtime * Fix sudo mock * Fix tests - part I; Fix storage and builder * Fix tests - part I * Fix tests - pips committee * Fix settlement tests; Add subsidiser to tx_payment pallet * Fix relayer tests * Fix tx_payment tests * Fix Utility tests * Compile staking tests * Fix staking tests - UseNominatorsAndValidatorsMap does not sort * Fix toml files missing runtime-benchmark feature * Fix toml files for benchmarks part II * Fix benchmarks - part III * Order toml dependencies * Update .lock; Change rust-toolchain * Change rust version * Fix benchmarks build * Change rust version for ci * Run cargo fmt * Fix the ci pipeline; Remove contracts from benchmarks temporarily * FIx manual_slash benchmark * Build docker temporarily * Add CA certs to debian docker image. * FIXUP: ca cert install * Remove unimplemented call * Add migrations (#1850) * update Cargo.lock * Fix CI pipeline. * FIXUP: ci pipeline. * Add missing pallet_contract migrations. * Fix Rust integration build with v8 chain metadata. * Update tests to use TransferWithMemo event. * Update TS integration tests. * Fix Rust integration build against v8. * Fix initial funding amounts. * Update Substrate to fix CheckNonce. * Fix proofSize limit for contract calls. * Bump transaction version to 8. --------- Co-authored-by: Robert G. Jakabosky <rjakabosky+neopallium@neoawareness.com>

* Update Substrate deps to stable2512. * Fix runtime_interface for benchmark host functions. * Fix runtime build errors. * Fix runtime compile errors. * Fix staking tests. * Fix node services code. * Use polymesh builder tool again. * cargo update. Update non-substrate deps. * Use the Sudo pallet from Substrate instead of our forked version. * Move Substrate Staking tests to Validators pallet. * Don't rustfmt the Staking test code. * Cleanup some TODOs. * Update branches in CI pipeline. * Store runtimes as artifacts of CI jobs. * Fix CI pipeline config. * Remove PR branch from CI pipeline.

* Fix migration of permissioned validators from Staking pallet. * Bump spec.

…`total_weight` (#1863) * Fix fee withdraw * Fix tests; Improve validate and prepare code * Change total_weight to call_weight * Remove duplicated check in tx extension; Fix call_weight usage * Another call_weight -> total_weight fix. --------- Co-authored-by: Robert G. Jakabosky <rjakabosky+neopallium@neoawareness.com>

* Reuse pallet-transaction-payment from Substrate, split our ChargeTransactionPayment code out. * Use improved transaction priority calculation from Substrate. * Implement support for disable fees. * Add benchmark of ChargeTransactionPayment tx extension. * Benchmark ChargeTransactionPayment extension. * Return the extension weight. * Use git paths instead of version for Substrate deps. * Update to Substrate release polkadot-stable2512. * Fix tests build.

… unused code

…hecks-with-did

Neopallium

Here are some initial comments.

Neopallium · 2026-02-03T09:06:31Z

primitives/src/constants.rs

        let value = match self {
            SystematicIssuers::Committee => "Committee",
-            SystematicIssuers::CDDProvider => "CDD Trusted Providers",
+            SystematicIssuers::DIDRegistrar => "DID Registrars",


Please leave these issuers as-is. We don't need one for DID providers, since they don't need to be issued a CDD claim.

Neopallium · 2026-02-03T09:08:07Z

primitives/src/authorization.rs

 #[derive(Clone, Debug, Deserialize, TypeInfo, Serialize)]
 pub enum AuthorizationData<AccountId> {
-    /// CDD provider's attestation to change primary key
+    /// DID registrar's attestation to change primary key


This authorization variant was never used and we don't need it anymore. For now just mark it as deprecated.

Neopallium · 2026-02-03T09:09:37Z

primitives/src/cdd_id.rs

 use scale_info::TypeInfo;

-/// A CDD ID only has meaning to the CDD provider that issues a CDD claim.
+/// A CDD ID only has meaning to the DID registrar that issues a CDD claim.


DID providers will not issue claims. So the original comment is still correct. The CDD claim and this CDDId type can be used by other companies if they want to provide CDD services (instead of full KYC services).

Neopallium · 2026-02-03T09:14:34Z

pallets/validators/src/permissioned.rs

+            pallet_identity::Pallet::<T>::is_did_active(identity),
+            Error::<T>::IdentityIsMissingDID


Identity == DID (they are the same thing). The error here should be identity not found or doesn't exist, since an identity can't be missing a DID.

Neopallium · 2026-02-03T09:22:13Z

pallets/runtime/testnet/src/runtime.rs


    #[runtime::pallet_index(8)]
-    pub type CddServiceProviders = pallet_group::Pallet<Runtime, Instance2>;
+    pub type DidRegistrars = pallet_group::Pallet<Runtime, Instance2>;


This will require a storage migration, since the pallet name is used in the storage key.

This reverts commit 5b43d03.

…dId comment

Neopallium · 2026-02-03T14:01:23Z

Items from the meeting:

Don't need to call is_did_active for the sender of assets, only the receiver.
If we get the identity from an on-chain lookup (e.g. query the caller's identity from their account id), we should only do a is_did_locked check. For now the is_did_locked method will just return true.

HenriqueNogara · 2026-02-04T22:12:09Z

pallets/identity/src/lib.rs

+        )]
        #[pallet::weight(<T as Config>::WeightInfo::cdd_register_did(secondary_keys.len() as u32))]
        #[pallet::call_index(0)]
        pub fn cdd_register_did(


@Neopallium Since we will be adding this for v8.0, can't we just remove this? The same applies to all deprecated extrinsics

Neopallium and others added 28 commits October 25, 2025 03:46

Update balance pallet (#1833)

f678125

* Remove pallet-balances * Fix benchmarks * Remove cdd check; Fix bench * Fix bench and integration tests * Add polymesh_v8 feature to polymesh-api * Update ci commands * Change ci flag * Remove error

Fix validators migration (#1858)

3bc74ac

* Fix migration of permissioned validators from Staking pallet. * Bump spec.

Add Beefy, Beefy-MMR and MMR pallets.

508d2f7

Add migration for SessionKeys. Allow Beefy to be disabled.

848f947

Add AuthorizedCall and CheckNonZeroSender tx extensions.

e9d8ced

Add WeightReclaim tx extension.

f84a0ba

Add support for CheckMetadataHash tx extension.

88f4f87

Fix Rust integration tests to support CheckMetadataHash tx extension.

f64537b

Support metadata-hash.

a190269

Migrate to FungibleAdapter.

5d67fc0

Fix staking election in Genesis block for dev chains.

12b36b8

replace cdd claim checks with did checks, rename errors/types, remove…

2d7d1f5

… unused code

rename CddServiceProviders to DidRegistrars

38e5a12

add register_did extrinsic, deprecate old extrinsics

17e5f58

add register_did tests and update naming in tests

1dde430

rename cdd provider leftovers in benchmarking and tests

7fe5e48

Merge branch 'polymesh-v8-next-features' into MESH-2295-replace-cdd-c…

8049060

…hecks-with-did

cleanup and check did active in benchmark

9914822

rename SystematicIssuers::CDDProvider to DIDRegistrar

5b43d03

update polymesh_schema.json and chain spec files

74d47c6

update cli types

e66309f

update tests

123ce7b

tgntr requested review from HenriqueNogara and Neopallium February 3, 2026 08:44

cleanup unused imports + fix ts integration tests

48ff3dc

Neopallium reviewed Feb 3, 2026

View reviewed changes

tgntr added 3 commits February 3, 2026 12:43

Revert "rename SystematicIssuers::CDDProvider to DIDRegistrar"

d97c4d3

This reverts commit 5b43d03.

deprecate AttestPrimaryKeyRotation

08ce284

rename error IdentityIsMissingDID to IdentityDoesNotExist + revert Cd…

dc43031

…dId comment

tgntr added 4 commits February 4, 2026 10:38

allow deprecated

f9e5e7c

remove did check for sender and add is_did_locked stub

3aebfed

cleanup duplicate code

ec9e645

add storage migration for CddServiceProviders -> DidRegistrars

e3db855

HenriqueNogara reviewed Feb 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove CDD claim checks and add DID Registrars#1873

Remove CDD claim checks and add DID Registrars#1873
tgntr wants to merge 36 commits intopolymesh-v8-next-featuresfrom
MESH-2295-replace-cdd-checks-with-did

tgntr commented Feb 3, 2026 •

edited

Loading

Uh oh!

Neopallium left a comment

Uh oh!

Neopallium Feb 3, 2026

Uh oh!

Neopallium Feb 3, 2026

Uh oh!

Neopallium Feb 3, 2026

Uh oh!

Neopallium Feb 3, 2026

Uh oh!

Neopallium Feb 3, 2026

Uh oh!

Neopallium commented Feb 3, 2026

Uh oh!

HenriqueNogara Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		pallet_identity::Pallet::<T>::is_did_active(identity),
		Error::<T>::IdentityIsMissingDID

Conversation

tgntr commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

changelog

new features

other

Uh oh!

Neopallium left a comment

Choose a reason for hiding this comment

Uh oh!

Neopallium Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Neopallium Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Neopallium Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Neopallium Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Neopallium Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Neopallium commented Feb 3, 2026

Uh oh!

HenriqueNogara Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tgntr commented Feb 3, 2026 •

edited

Loading