Portaudio with Oboe Implementation

[hopefulGiupplo]

As I said in this issue, I finally can say that this PaOboe implementation seems to be working.
Instruction to how to build PortAudio with Oboe are detailed in src/hostapi/oboe/Readme.md

[hopefulGiupplo]

Hello @philburk, I saw you assigned this issue to yourself. Please let me know if I can help :)

[hopefulGiupplo]

Hello @philburk and PA team, I'm here to ask if I can help with any changes, and to ask if you're planning to include pa_oboe in portaudio's next release :) I rebased this work onto the last additions, I hope the library is still correctly built.
Please ping me if there's anything I can do!

[philburk]

Thanks for rebasing this code.
We are trying to get the next release out soon.
This PR will need a deep review and then after it is merged it will need some soak time for other to try it.
So I don't think it will make the next release.

I will try to review in depth soon. The code looks very good so far.

[philburk]

The missing comma is causing it to fail CI.

[RossBencina]

Hi @hopefulGiupplo, thanks for your contribution, it's looking good but I agree that Phil needs to do a thorough review since he is the Oboe expert. Some other things that would help:

• It's not passing CI at the moment, you will need to keep on top of that
• It would help if there were some additional testers for your code, if you think that it's ready (and once CI is passing) you could post to the mailing list and request that other people try it
• If anyone else is already using this it would be good to hear their feedback here (both in terms of using the implementation and reviewing the source code).

Once Phil is satisfied I will also do a code review.

[acolombier]

Hi, I have tested this feature, alongside couple of implementation changes (no "default" devices, leverage HostApiSpecificStreamInfo to control oboe specific settings such as performance or usage) and it work great. Note that there is one major flaw, which doesn't allow to properly shutdown a stream. I know you have a good knowledge of oboe @philburk so perhaps you have an idea what is wrong with this approach?

Are you still interested to carry this feature forward @hopefulGiupplo ? Happy to spin up a new PR otherwise.

[hopefulGiupplo]

Hello @acolombier , right now I've got my hands full, but I'd still need this development, and it would be amazing if it could be finally integrated in Portaudio. Feel free to open a new PR, I'll try to keep track of your changes as the project is finalizing.

@philburk let me know if you prefer this PR to remain open after acolombier opens theirs

[philburk]

@hopefulGiupplo wrote:

Feel free to open a new PR,

Thanks you for this huge contribution.

I see that @acolombier created #1084.
Since you and he seem to be in agreement that the work should continue in #1084,
we can do the review in that PR and close this one.
You can close it or I can.
See you in #1084