Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/return model in response #982

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

narengogi
Copy link
Collaborator

@narengogi narengogi commented Mar 11, 2025

@narengogi narengogi marked this pull request as ready for review March 11, 2025 12:50
@narengogi narengogi requested review from VisargD and b4s36t4 March 11, 2025 12:51
@narengogi narengogi self-assigned this Mar 11, 2025
@@ -149,7 +150,8 @@ export async function responseHandler(
response,
responseTransformerFunction,
strictOpenAiCompliance,
gatewayRequestUrl
gatewayRequestUrl,
gatewayRequest
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would much prefer just passing all of these as an object that can be destructured, let me know if you want that change to be done, just put it off because that would mean changes in every provider transform function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant