Add upload option to sourcemaps config

[joeriddles]

Problem

People who want to upload source maps to PostHog in a separate CI workflow than their build process.

Source map uploading is slow and can be ran parallel in a separate workflow.

Changes

Add upload option to the Next.js/Rollup/Webpack sourcemaps config. When false, posthog-cli sourcemap inject is used. When true (default), @posthog/cli sourcemap process is used, which injects and uploads.

Release info Sub-libraries affected

Libraries affected

• All of them
• posthog-js (web)
• posthog-js-lite (web lite)
• posthog-node
• posthog-react-native
• @posthog/react
• @posthog/ai
• @posthog/nextjs-config
• @posthog/nuxt
• @posthog/rollup-plugin
• @posthog/webpack-plugin
• @posthog/types

Checklist

• Tests for new code
  • There are no existing tests for any of the modified packages
• Accounted for the impact of any changes across different platforms
• Accounted for backwards compatibility of any changes (no breaking changes!)
  • Default option is to upload sourcemaps
• Took care not to unnecessarily increase the bundle size

If releasing new changes

• Ran pnpm changeset to generate a changeset file
• Added the "release" label to the PR to indicate we're publishing new versions for the affected packages

[vercel]

@joeriddles is attempting to deploy a commit to the PostHog Team on Vercel.

A member of the Team first needs to authorize it.

[greptile-apps]

Additional Comments (3)

1. packages/rollup-plugin/src/index.ts, line 89-94 (link)

   logic: deleteAfterUpload and batchSize only apply when uploading - these checks should be inside the if (posthogOptions.sourcemaps.upload) block, since sourcemap inject doesn't support these flags

2. packages/webpack-plugin/src/index.ts, line 87-93 (link)

   logic: deleteAfterUpload and batchSize only apply when uploading - these checks should be inside the if (config.sourcemaps.upload) block, since sourcemap inject doesn't support these flags

3. packages/nextjs-config/src/utils.ts, line 38-44 (link)

   logic: deleteAfterUpload and batchSize only apply when uploading - these checks should be inside the if (posthogOptions.sourcemaps.upload) block, since sourcemap inject doesn't support these flags

_{4 files reviewed, 8 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (2)

1. packages/webpack-plugin/src/index.ts, line 87-93 (link)

   syntax: wrap these checks in if (config.sourcemaps.upload) conditional - when upload is false, deleteAfterUpload and batchSize don't exist on the discriminated union type

2. packages/nextjs-config/src/utils.ts, line 37-43 (link)

   syntax: wrap these checks in if (posthogOptions.sourcemaps.upload) conditional - when upload is false, deleteAfterUpload and batchSize don't exist on the discriminated union type

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[joeriddles]

I'm having a hard time testing this in a separate project with my forked branch. I didn't see any advice in CONTRIBUTING.md for testing forked versions of this repo. I'm running into issues since the internal packages use workspace:* for dependencies on other internal packages. Any advice here?

[hpouillot]

@joeriddles Just to be sure to understand the use case, do you want to build once and upload sourcemaps in multiple environments in parallel ? What is the workflow you want to achieve ?

[hpouillot]

Do you have any errors when you run 'pnpm install' in the workspace ?

[github-actions]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.