fix: session recording persisted config should have cache invalidation#3051
Open
pauldambra wants to merge 1 commit intomainfrom
Open
fix: session recording persisted config should have cache invalidation#3051pauldambra wants to merge 1 commit intomainfrom
pauldambra wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60dd5dd07f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/browser/src/extensions/replay/external/lazy-loaded-session-recorder.ts
Outdated
Show resolved
Hide resolved
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
packages/browser/src/extensions/replay/external/lazy-loaded-session-recorder.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Size Change: +822 B (+0.01%) Total Size: 5.9 MB
ℹ️ View Unchanged
|
pauldambra
force-pushed
the
fix/pd/cache-invalidation
branch
from
60dd5dd to
14d2f96
Compare
pauldambra
force-pushed
the
fix/pd/cache-invalidation
branch
from
14d2f96 to
e10b6ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session replay persists remote config and starts proactively when it is present
this is because it can be relatively slow to start recording and on a site with full page loads on navigation we would lose some recording
but it has no cache invalidation
Ruh-roh, Raggy!
This change
that means all existing caches are immediately invalidated but that's fine, it's a proactive prevention and will mean we just behave like a full page load from fresh
and it means all invalid caches will stop being respected which is causing unwanted recordings particularly obviously on high traffic sites