fix: avoid return from finally block to fix Python 3.14 SyntaxWarning

[jodal]

This fixes a SyntaxWarning on Python 3.14.

❯ uvx --no-cache --python 3.14.0 --with posthog==6.7.11 python -c "import posthog"
Installed 11 packages in 5ms
.../lib/python3.14/site-packages/posthog/consumer.py:92: SyntaxWarning: 'return' in a 'finally' block
  return success

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[Copilot]

Pull request overview

This PR fixes a SyntaxWarning that occurs when running the posthog library on Python 3.14 by moving a return statement from inside a finally block to outside of it.

Key Changes:

• Moved the return success statement from inside the finally block to after it in the upload() method

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pauldambra]

let's at least wait until #403 is merged

i want to be sure we don't break one thing while fixing another

when #403 is merged can you update this PR

[jodal]

I've rebased the PR and made it log and swallow any errors from the on_error handler to keep the old behavior where the return in the finally clause implicitly swallowed any errors in the except block.

[pauldambra]

the log is a good touch for a previously totally silent error 👍

[pauldambra]

@Piccirello i can't merge here because

Merging is blocked
Code scanning is waiting for results from CodeQL for the commits db70702 or ae32dfc.

i'm guessing that's because it's external?

you-are-our-only-hope.meme

[Piccirello]

CodeQL requires you to setup CodeQL Advanced in a repo in order to run it against external contributor PRs (super annoying). We've started setting this up in repos as it pops up, like in posthog, posthog-android, posthog-ios. #405 should fix this.

[rafaeelaudibert]

@jodal, I've merged @Piccirello's #405, but we now need you to merge your branch with the current master to get CodeQL to run. Do you mind doing that?

[pauldambra]

one more ping, i can't figure out how to update this to master myself, sorry!
if you can bring this up-to-date, codeql should run and we're good to rock and roll

[jodal]

Rebased again.

[Piccirello]

I've enabled the repo setting "Always suggest updating pull request branches", which will now show the “update branch” option.