Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH actions - misc-dailies.yml: run job validate-pip-hashes also on pull request events #15150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romeroalx
Copy link
Member

Short description

This PR modifies the workflow misc-dailies.yml for running the job validate-pip-hashes also on pull request events.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK, but it feels weird to have jobs of the daily checks workflow executed on pull requests. Perhaps we could move these checks to a separate workflow (or to a reusable workflow if we want to keep it calling it from here)?

@romeroalx
Copy link
Member Author

The changes look OK, but it feels weird to have jobs of the daily checks workflow executed on pull requests. Perhaps we could move these checks to a separate workflow (or to a reusable workflow if we want to keep it calling it from here)?

Makes sense, good idea! I will move it to a separate and reusable workflow. Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13306224685

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 44 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.003%) to 64.72%

Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/dnsdistdist/dnsdist-backend.cc 1 66.19%
pdns/pollmplexer.cc 1 83.66%
pdns/distributor.hh 2 51.86%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/communicator.cc 3 71.85%
pdns/iputils.hh 3 78.23%
pdns/communicator.hh 3 77.04%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
pdns/dnsdistdist/dnsdist-carbon.cc 6 62.23%
Totals Coverage Status
Change from base Build 13305454892: 0.003%
Covered Lines: 128194
Relevant Lines: 167043

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants