Use rclone instead of custom sync script to publish documentation to AWS S3 bucket

[milzi234]

Short description

Publishing documentation to AWS S3 has been slow, likely due to the custom publish.js script overwriting all files. This patch uses rclone instead, which uses digests to figure out which files to actually upload. This also means we don't have to use the javascript script anymore and don't need to install all the node dependencies for the aws sdk, which will likely also save time.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[rgacogne]

That's brilliant, nice work!

[coveralls]

Pull Request Test Coverage Report for Build 13326611785

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 52 unchanged lines in 9 files lost coverage.
• Overall coverage increased (+0.2%) to 64.583%

---

Files with Coverage Reduction	New Missed Lines	%
pdns/backends/gsql/gsqlbackend.hh	2	97.71%
pdns/dnsdistdist/dnsdist-async.cc	2	81.51%
pdns/rcpgenerator.cc	2	90.55%
pdns/recursordist/test-syncres_cc2.cc	3	88.85%
pdns/remote_logger.cc	3	57.4%
pdns/dnsdistdist/dnsdist.cc	4	68.79%
pdns/dnsdistdist/dnsdist-carbon.cc	6	62.23%
ext/json11/json11.cpp	13	62.72%
modules/godbcbackend/sodbc.cc	17	70.8%

Totals
Change from base Build 13325621226:	0.2%
Covered Lines:	127829
Relevant Lines:	166866

---

💛 - Coveralls

[miodvallat]

Stupid question, is it important to pass --progress to rclone? Shouldn't we aim for the tersest possible output?

[rgacogne]

DNSdist CI failure is unrelated, see #15156

[Habbie]

the VM gets destroyed right after this anyway, but it can't hurt