Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Generate tarballs via meson dist #15163

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

rgacogne
Copy link
Member

Short description

This PR mimics what was done for the recursor, allowing DNSdist tarballs to be generated via meson. The resulting tarball builds fine, and looking at the differences with the same tarball generated via autotools did not show any issue (there are some differences, mostly generated files that are present in the meson-generated tarball and not in the autotools one. If anything this is a missing optimization in the autotools version). htmlfiles.h is included in the autotools version and not in the meson one, but that does not seem to be an issue.
It also includes the man-pages optimization added to the recursor in #15161.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GH UI is confused by the "delete symlink, replace with new file" cinematic so I can't attach comments to the new gen-version there.

Line 13, typo: consequenses -> consquences
Line 56 is -> if

@rgacogne
Copy link
Member Author

The GH UI is confused by the "delete symlink, replace with new file" cinematic so I can't attach comments to the new gen-version there.

Line 13, typo: consequenses -> consquences Line 56 is -> if

Ah nice, we will have to fix these in three places now :D

@miodvallat
Copy link
Contributor

Ah nice, we will have to fix these in three places now :D

That's the only way you'll eventually learn to write english correctly! 😈

@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13366145810

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 352 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.1%) to 64.486%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-tcp.cc 1 76.33%
pdns/misc.cc 1 62.46%
pdns/recursordist/recursor_cache.cc 1 84.16%
pdns/arguments.cc 2 58.82%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/tcpiohandler.cc 2 68.18%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
pdns/axfr-retriever.cc 3 66.94%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/dnsdistdist/dnsdist-carbon.cc 6 62.77%
Totals Coverage Status
Change from base Build 13328955165: -0.1%
Covered Lines: 127604
Relevant Lines: 166873

💛 - Coveralls

@rgacogne
Copy link
Member Author

The GH UI is confused by the "delete symlink, replace with new file" cinematic so I can't attach comments to the new gen-version there.

Line 13, typo: consequenses -> consquences Line 56 is -> if

I just pushed a commit fixing these typos, thanks!

@rgacogne rgacogne merged commit 28e5cd4 into PowerDNS:master Feb 17, 2025
83 checks passed
@rgacogne rgacogne deleted the dnsdist-meson-dist branch February 17, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants