-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsdist: Generate tarballs via meson dist
#15163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GH UI is confused by the "delete symlink, replace with new file" cinematic so I can't attach comments to the new gen-version
there.
Line 13, typo: consequenses
-> consquences
Line 56 is
-> if
Ah nice, we will have to fix these in three places now :D |
That's the only way you'll eventually learn to write english correctly! 😈 |
Pull Request Test Coverage Report for Build 13366145810Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I just pushed a commit fixing these typos, thanks! |
Short description
This PR mimics what was done for the recursor, allowing DNSdist tarballs to be generated via
meson
. The resulting tarball builds fine, and looking at the differences with the same tarball generated viaautotools
did not show any issue (there are some differences, mostly generated files that are present in themeson
-generated tarball and not in theautotools
one. If anything this is a missing optimization in theautotools
version).htmlfiles.h
is included in theautotools
version and not in themeson
one, but that does not seem to be an issue.It also includes the
man-pages
optimization added to the recursor in #15161.Checklist
I have: