Improve LMDBBackend reliability #15175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the LMDBBackend destructor is invoked while there are still pending transactions, these need to be aborted, but in the reverse order of their creation (i.e. abort the innermost transaction first). The default destructor would abort them in a class field declaration-dependent order, which may not match the actual cinematic. We now remember which transaction is the innermost one, so that we can abort them in the expected order. This gets rid of "double free or corruption (top)" aborts with glibc, and Address Sanitizer errors.
Habbie
approved these changes
Feb 19, 2025
Pull Request Test Coverage Report for Build 13409190143Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Recent tinkering made me discover the hard way that, in some corner (error) cases, I could get a double
freein theLMDBBackenddestructor.Further investigation showed that we can end up with two active LMDB transactions; these need to be aborted in the reverse order of their creation, and, well, this wasn't always the case.
This PR fixes this problem.
Checklist
I have: