Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist-1.9.x: Handle Quiche >= 0.23.0 since the API changed #15183

Merged

Conversation

rgacogne
Copy link
Member

Short description

Backport of #15118 to dnsdist-1.9.x: Quiche 0.23.0 has renamed quiche_h3_event_headers_has_body to quiche_h3_event_headers_has_more_frames, so we need to handle that.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Quiche 0.23.0 has renamed `quiche_h3_event_headers_has_body` to
`quiche_h3_event_headers_has_more_frames`, so we need to handle that.

(cherry picked from commit 35ab1db)
@rgacogne rgacogne added this to the dnsdist-1.9.x milestone Feb 20, 2025
@rgacogne rgacogne closed this Feb 20, 2025
@rgacogne rgacogne reopened this Feb 20, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13434024682

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 55.735%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/doh3.cc 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/pollmplexer.cc 1 82.39%
pdns/iputils.hh 2 74.89%
pdns/misc.cc 2 40.12%
pdns/dnsdist-carbon.cc 6 59.62%
Totals Coverage Status
Change from base Build 13434000047: -0.02%
Covered Lines: 48165
Relevant Lines: 65735

💛 - Coveralls

@rgacogne rgacogne merged commit a606ca3 into PowerDNS:rel/dnsdist-1.9.x Feb 20, 2025
17 of 22 checks passed
@rgacogne rgacogne deleted the ddist19-backport-15118 branch February 20, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants