fix: Check Type instance has DscResource attribute #812
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch @haodeon! |
Comment on lines
228
to
229
| if ($classBased -and ($instance.GetProperties() | Where-Object { | ||
| $_.CustomAttributes.AttributeType.Name -eq 'DscPropertyAttribute' } | Select-Object -First 1)) { | ||
| "Detected class-based resource: $($dscResource.Name) => Type: $($classBased.BaseType.FullName)" | Write-DscTrace |
There was a problem hiding this comment.
Instead of checking the properties, you can check whether the class has the [DscResource()] attribute - any class with that attribute is checked for validity as a PSDSC resource at parse time - those checks (that you have the correct method signatures, at least one key property, etc) are built directly into the parser.
There was a problem hiding this comment.
Code now checks for DscResource attribute instead of scanning properties for DscProperty attribute.
haodeon
force-pushed
the
fix/winPS-ClassBased
branch
from
00d97b2 to
e7e6292
Compare
haodeon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR #797 introduced a workaround to detect if DSC resources were
ClassBased. This PR adds an additional validation by checking the instance has theDscResourceattribute.PR Context
The workaround incorrectly sets
ImplementationDetailtoClassBasedwhen there is another type with the same name, likeTimeZoneorEnvironment.