Skip to content

Conversation

totkeks
Copy link

@totkeks totkeks commented Feb 7, 2025

PR Summary

Adds new conditions to handle surrogate pairs when calculating the buffer length of a string.

Fixes #3857.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
Microsoft Reviewers: Open in CodeFlow

@totkeks
Copy link
Author

totkeks commented Feb 8, 2025

@microsoft-github-policy-service agree

@springcomp
Copy link
Contributor

I think this pull request needs a unit-test to demonstrate the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using an emoji as the prompt text parse error replacement causes glitchy text to remain in the text buffer
2 participants