Fix dependency resolution order and reduce transient reconciliation errors#208
Merged
chrisguidry merged 2 commits intomainfrom Sep 22, 2025
Merged
Fix dependency resolution order and reduce transient reconciliation errors#208chrisguidry merged 2 commits intomainfrom
chrisguidry merged 2 commits intomainfrom
Conversation
…rrors Addresses cascading dependency failures and error noise that occurred when applying Prefect resources simultaneously. The main issue was deployments attempting to sync before their referenced work pools existed in the Prefect API, causing repeated "work pool not found" errors. Changes made: - Add work pool dependency validation in deployment controller before sync attempts - Improve Ready status semantics to reflect sync success rather than Prefect API status - Reduce requeue intervals from 5 minutes to 10 seconds for faster user feedback - Add utility functions for server health checking and backoff strategies Testing methodology involved systematic reproduction of the issue using minikube + `make install run` + `deployment_end-to-end.yaml`, then iterative testing to verify the fix eliminates error spam while maintaining functionality. Integration tests confirm all resources reach Ready state reliably with clean logs. Closes #199 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
There was a problem hiding this comment.
(non-blocking thought): I wonder if either of these packages would help here to avoid writing our own backoff logic.
mitchnielsen
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cascading dependency failures and error noise that occurred when applying Prefect resources simultaneously. The main issue was deployments attempting to sync before their referenced work pools existed in the Prefect API, causing repeated "work pool not found" errors and confusing log spam.
Key Changes
Testing Methodology
The fix was developed using systematic integration testing:
minikube+make install run+deploy/samples/deployment_end-to-end.yamlto reproduce the exact errors described in the issueBefore/After Comparison
Before:
After:
Integration Test Results
✅ PrefectServer: Ready immediately
✅ PrefectWorkPool: Ready when workers are available
✅ PrefectDeployment: Ready within ~10 seconds after sync
✅ Clean logs: Minimal error noise with actionable messages
✅ No regressions: All existing functionality preserved
Closes #199
🤖 Generated with Claude Code