Skip to content

Missing required param for url #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Triloworld wants to merge 2 commits into from
Closed

Missing required param for url #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2142cd3
Missing required param for url
Triloworld Aug 9, 2024
865ea7f
Add backend check for image_url
Triloworld Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ps_imageslider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,9 @@ protected function _postValidation()
if (Tools::getValue('image_old_' . $language['id_lang']) != null && !Validate::isFileName(Tools::getValue('image_old_' . $language['id_lang']))) {
$errors[] = $this->trans('Invalid filename.', [], 'Modules.Imageslider.Admin');
}
if (!Tools::isSubmit('has_picture') && (!isset($_FILES['image_' . $language['id_lang']]) || empty($_FILES['image_' . $language['id_lang']]['tmp_name']))) {
$errors[] = $this->trans('The image is not set.', [], 'Modules.Imageslider.Admin');
}
}

/* Checks title/legend/description for default lang */
Expand Down Expand Up @@ -613,10 +616,12 @@ public function hookActionShopDataDuplication($params)

public function headerHTML()
{
if ('AdminModules' !== Tools::getValue('controller') ||
if (
'AdminModules' !== Tools::getValue('controller') ||
Tools::getValue('configure') !== $this->name ||
Tools::getIsset('id_slide') ||
Tools::getIsset('addSlide')) {
Tools::getIsset('addSlide')
) {
return;
}

Expand Down Expand Up @@ -677,8 +682,8 @@ public function getSlides($active = null, $forceShowAll = false)
LEFT JOIN ' . _DB_PREFIX_ . 'homeslider_slides_lang hssl ON (hss.id_homeslider_slides = hssl.id_homeslider_slides)
WHERE id_shop = ' . (int) $id_shop . '
AND hssl.id_lang = ' . (int) $id_lang .
($forceShowAll ? '' : ' AND hssl.`image` <> ""') .
($active ? ' AND hss.`active` = 1' : ' ') . '
($forceShowAll ? '' : ' AND hssl.`image` <> ""') .
($active ? ' AND hss.`active` = 1' : ' ') . '
ORDER BY hss.position'
);

Expand All @@ -705,7 +710,7 @@ public function getAllImagesBySlidesId($id_slides, $active = null, $id_shop = nu
LEFT JOIN ' . _DB_PREFIX_ . 'homeslider_slides hss ON (hs.id_homeslider_slides = hss.id_homeslider_slides)
LEFT JOIN ' . _DB_PREFIX_ . 'homeslider_slides_lang hssl ON (hss.id_homeslider_slides = hssl.id_homeslider_slides)
WHERE hs.`id_homeslider_slides` = ' . (int) $id_slides . ' AND hs.`id_shop` = ' . (int) $id_shop .
($active ? ' AND hss.`active` = 1' : ' ')
($active ? ' AND hss.`active` = 1' : ' ')
);

foreach ($results as $result) {
Expand Down